This repository was archived by the owner on Jul 31, 2025. It is now read-only.
Bump go version to 1.7.1, since 1.6.3 cannot build working binaries on OS X Sierra #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
force-pushed
the
bump-to-go1.7.1-for-sierra
branch
from
3f62c24 to
a22e76f
Compare
riyazdf
approved these changes
Sep 30, 2016
Contributor
riyazdf
left a comment
riyazdf
left a comment
There was a problem hiding this comment.
thank you for fixing this, LGTM on green!
| @@ -1 +1 @@ | |||
| 0.4.1 | |||
| 0.4.2 | |||
Contributor
There was a problem hiding this comment.
Can we also make a quick changelog note?
cyli
force-pushed
the
bump-to-go1.7.1-for-sierra
branch
from
a22e76f to
43850f7
Compare
riyazdf
reviewed
Sep 30, 2016
| # Changelog | ||
|
|
||
| ## [v0.4.2](https://github.com/docker/notary/releases/tag/v0.4.0) 9/30/2016 | ||
| + Bump the cross compiler to golang 1.7.1, since [1.6.3 builds binaries that could have non-deterministic bugs in OS X Sierra](https://groups.google.com/forum/#!msg/golang-dev/Jho5sBHZgAg/cq6d97S1AwAJ) [#984](https://github.com/docker/notary/pull/984) |
Contributor
Author
|
@justincormack approved. ping @endophage for one more +1? |
…n Mac OS Sierra Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
bump-to-go1.7.1-for-sierra
branch
from
43850f7 to
8e602b9
Compare
Signed-off-by: Ying Li <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:|
See https://groups.google.com/forum/#!msg/golang-dev/Jho5sBHZgAg/cq6d97S1AwAJ