CSV | Allow configuring amount of characters per line in CSV extractor #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
force-pushed
the
csv-line-length
branch
from
5efbac3 to
dcfbe89
Compare
norberttech
reviewed
Sep 30, 2022
...adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Fixtures/more_than_1000_characters_per_line.csv
Show resolved
Hide resolved
norberttech
reviewed
Sep 30, 2022
src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Integration/CSVExtractorTest.php
Outdated
Show resolved
Hide resolved
norberttech
reviewed
Sep 30, 2022
src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Integration/CSVExtractorTest.php
Outdated
Show resolved
Hide resolved
stloyd
force-pushed
the
csv-line-length
branch
3 times, most recently
from
8d8ffad to
26d475e
Compare
stloyd
force-pushed
the
csv-line-length
branch
from
26d475e to
1fe9ff6
Compare
Member
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Big CSV export files can have way more than 1000 characters, especially since we need to count also all separators and escaping characters.