add pack to haddock equalities for scanl and iterate #114
Conversation
dcoutts
left a comment
dcoutts
left a comment
There was a problem hiding this comment.
But actually, perhaps the legit other way to resolve this is to make the original list style code correct by making ByteString an instance of IsList so that OverloadedLists work :-) This would actually be quite easy.
| -- reduced values from the left. This function will fuse. | ||
| -- | ||
| -- > scanl f z [x1, x2, ...] == [z, z `f` x1, (z `f` x1) `f` x2, ...] | ||
| -- > scanl f z [x1, x2, ...] == pack [z, z `f` x1, (z `f` x1) `f` x2, ...] |
There was a problem hiding this comment.
If we're doing this we'd need to be consistent, so that'd be pack on both lists.
There was a problem hiding this comment.
IMHO this isn't a great improvement – it's easy to see that the list notation represents the bytes of a ByteString. If we apply pack consistently, I believe the increased visual noise would probably make this less readable than the current state.
Regarding @dcoutts' idea of an IsList instance – that seems like a reasonable idea to me, given that the Item type is Word8.
|
Superseded by #219 |
4 participants
Resolves #106