Skip to content

Commit 371e3d7

Browse files
lukefromdcraveit65
authored andcommitted
fix crash on removing tray
*clear applet gsettings on dispose to stop crash and memory leak introduced in github.com/mate-desktop/mate-panel/commit/10b9c30fc79de5f8d9516ba153df233c4968da65 *tray: fix misplaced g_return_if_fail check
1 parent c733d20 commit 371e3d7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

‎applets/notification_area/main.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ na_tray_applet_realize (GtkWidget *widget)
333333
static void
334334
na_tray_applet_dispose (GObject *object)
335335
{
336+
g_clear_object (&NA_TRAY_APPLET (object)->priv->settings);
336337
#ifdef PROVIDE_WATCHER_SERVICE
337338
g_clear_object (&NA_TRAY_APPLET (object)->priv->sn_watcher);
338339
#endif

‎applets/notification_area/na-grid.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,9 @@ void
183183
na_grid_set_min_icon_size (NaGrid *grid,
184184
gint min_icon_size)
185185
{
186-
grid->min_icon_size = min_icon_size;
187-
188186
g_return_if_fail (NA_IS_GRID (grid));
187+
188+
grid->min_icon_size = min_icon_size;
189189

190190
refresh_grid (grid);
191191
}

0 commit comments

Comments
 (0)