Skip to content

Commit 7c692bd

Browse files
committed
pluma-file-browser-widget.c: avoid deprecated GtkImageMenuItem
avoid deprecated: gtk_image_menu_item_new_with_label gtk_image_menu_item_set_image
1 parent 6ab8350 commit 7c692bd

File tree

3 files changed

+35
-8
lines changed

3 files changed

+35
-8
lines changed

‎plugins/filebrowser/pluma-file-browser-widget.c‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -984,6 +984,9 @@ create_toolbar (PlumaFileBrowserWidget * obj,
984984

985985
/* Previous directory menu tool item */
986986
obj->priv->location_previous_menu = gtk_menu_new ();
987+
988+
gtk_menu_set_reserve_toggle_size (GTK_MENU (obj->priv->location_previous_menu), FALSE);
989+
987990
gtk_widget_show (obj->priv->location_previous_menu);
988991

989992
widget = GTK_WIDGET (gtk_menu_tool_button_new (gtk_image_new_from_icon_name ("go-previous",
@@ -1007,6 +1010,9 @@ create_toolbar (PlumaFileBrowserWidget * obj,
10071010

10081011
/* Next directory menu tool item */
10091012
obj->priv->location_next_menu = gtk_menu_new ();
1013+
1014+
gtk_menu_set_reserve_toggle_size (GTK_MENU (obj->priv->location_next_menu), FALSE);
1015+
10101016
gtk_widget_show (obj->priv->location_next_menu);
10111017

10121018
widget = GTK_WIDGET (gtk_menu_tool_button_new (gtk_image_new_from_icon_name ("go-next",
@@ -1532,7 +1538,6 @@ create_goto_menu_item (PlumaFileBrowserWidget * obj, GList * item,
15321538
GdkPixbuf * icon)
15331539
{
15341540
GtkWidget *result;
1535-
GtkWidget *image;
15361541
gchar *unescape;
15371542
GdkPixbuf *pixbuf = NULL;
15381543
Location *loc;
@@ -1547,14 +1552,8 @@ create_goto_menu_item (PlumaFileBrowserWidget * obj, GList * item,
15471552
}
15481553

15491554
if (pixbuf) {
1550-
image = gtk_image_new_from_pixbuf (pixbuf);
1555+
result = pluma_image_menu_item_new_from_pixbuf (pixbuf, unescape);
15511556
g_object_unref (pixbuf);
1552-
1553-
gtk_widget_show (image);
1554-
1555-
result = gtk_image_menu_item_new_with_label (unescape);
1556-
gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (result),
1557-
image);
15581557
} else {
15591558
result = gtk_menu_item_new_with_label (unescape);
15601559
}

‎pluma/pluma-utils.c‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,3 +1698,27 @@ pluma_gtk_text_iter_regex_search (const GtkTextIter *iter,
16981698
g_regex_unref (regex);
16991699
return found;
17001700
}
1701+
1702+
GtkWidget *
1703+
pluma_image_menu_item_new_from_pixbuf (GdkPixbuf *icon_pixbuf,
1704+
const gchar *label_name)
1705+
{
1706+
GtkWidget *icon;
1707+
GtkWidget *box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 6);
1708+
1709+
if (icon_pixbuf)
1710+
icon = gtk_image_new_from_pixbuf (icon_pixbuf);
1711+
else
1712+
icon = gtk_image_new ();
1713+
1714+
GtkWidget *label_menu = gtk_label_new (g_strconcat (label_name, " ", NULL));
1715+
GtkWidget *menuitem = gtk_menu_item_new ();
1716+
1717+
gtk_container_add (GTK_CONTAINER (box), icon);
1718+
gtk_container_add (GTK_CONTAINER (box), label_menu);
1719+
1720+
gtk_container_add (GTK_CONTAINER (menuitem), box);
1721+
gtk_widget_show_all (menuitem);
1722+
1723+
return menuitem;
1724+
}

‎pluma/pluma-utils.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,10 @@ pluma_gtk_text_iter_regex_search (const GtkTextIter *iter,
160160
gboolean forward_search,
161161
gchar **replace_text);
162162

163+
GtkWidget *
164+
pluma_image_menu_item_new_from_pixbuf (GdkPixbuf *icon_pixbuf,
165+
const gchar *label_name);
166+
163167
G_END_DECLS
164168

165169
#endif /* __PLUMA_UTILS_H__ */

0 commit comments

Comments
 (0)