SqlBuilder: Added alias support #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbe
force-pushed
the
kh-added-alias-support
branch
2 times, most recently
from
a8819a7 to
9521ed6
Compare
Contributor
Author
|
Can someone tell me what is wrong in SqlBuilder.addAlias().phpt? From "[FOUND] tests/Database/Table/SqlBuilder.addAlias().phpt -1 bytes of whitespaces" I really don't know what is wrong.. |
Contributor
|
You should use |
|
@norbe missing newline at end of file, see https://github.com/nette/database/pull/119/files#diff-736e93a1f9065b1b46a47c182c44e663R103 |
norbe
force-pushed
the
kh-added-alias-support
branch
from
9521ed6 to
f43aaf3
Compare
Contributor
Author
Contributor
Author
|
@dg Can I do somethink for merge of this feature? |
src/Database/Table/Selection.php
Outdated
|
|
||
|
|
||
| /** | ||
| * Alias table |
norbe
force-pushed
the
kh-added-alias-support
branch
from
f43aaf3 to
99fe59e
Compare
Contributor
Author
|
Anything else? |
Member
|
@norbe Thank you! |
Contributor
Author
|
Can I check coding standard automatically somehow for future? |
Member
|
Unfortunatelly I haven't tool for checking coding style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to specify alias for given table chain. Aliases can be even nested.
I have also added some checks if table alias is unique. Old behaviour in some cases silently skip tables or just works weird. It can found some hidden bugs in application. For example $context->table('book')->select('book.author.column') was translated to 'book.column'.