Do not suppress 'permission denied' warnings in FileUpload::move()

[OndrejSlamecka]

This commit adds more comprehensible error reporting to the move() method in the following scenarios:

• Say the program has insufficient permissions to create the directory dirname($dest). With this commit the move() method correctly raises mkdir(): Permission denied warning instead of warning raised by move_uploaded_file: failed to open stream: No such file or directory with previous code.
• Or the already existing file at $dest may not be deleted with the current permissions. With this commit a correct Permission denied warning is again raised by unlink instead of warning raised by move_uploaded_file with previous code.

[hrach]

You solution suffers with race condition problem.

[enumag]

Then how about keeping the original code and adding if (file_exists($dest)) { throw new ... }?

[OndrejSlamecka]

Good point and good suggestion, thank you. The commit above should prevent the problem at least to the level the previous code prevented such problems.

Is InvalidStateException the right one to be thrown?

[hrach]

Are you sure, that only reason why directory has not been created is the permission problem? :)

[OndrejSlamecka]

Right, inode limit comes to mind. I made the text more general with the commit above.

[JanTvrdik]

See nette/tracy#133

[dg]

What about call mkdir only when dir doesn't exist and remove @?

[Majkl578]

That wouldn't be atomic though.

[dg]

This issue is about suppressing, isn't it?

[Majkl578]

I replied to your previous comment:

call mkdir only when dir doesn't exist

[dg]

I understand.