SafeStream: prevents unnecessary error during register #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Could someone please tell me what is wrong with my test? I don't get the whitespace thing .. |
Member
|
Fix third party packages, this is absolutely correct. |
Contributor
Author
|
I disagree, because in Nette I understand it and I can adapt to it, but if it is affecting environment out of Nette, it is bad in my opinion (I am talking about project-managing helpful scripts). But hey, I can live with that. |
Member
|
There are a lot of places where PHP produces error and it is suppressed, so there always will be some last error. |
|
@salatos In PHP 7 you may call |
Contributor
Author
|
@JanTvrdik Thanks for the tip! Still please, what is wrong with my test (for the future contributing)? I can't figure it out .. or should I ask on phorum? Thanks alot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason of this changes is that if error during unregistration of stream happens, php remebers it even if it is suppressed. And SafeStream::register is called in composer autoloading process. So whenever is vendor/autoload.php used, it produces that error. Some third party packages displays the last error by error_get_last() function and it's annoying and unnecessary I think and it can be preveted by this fix.