-
Notifications
You must be signed in to change notification settings - Fork 19
fix(Dashboard): hides overflow for text #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find out why the outer element is growing so wide
|
Thanks a lot for looking into this!! |
61a0404 to
fb3714d
Compare
|
It's definitely better now, but I'm afraid this whole component structure needs a bit of a rewrite or a lot more duct tape. The padding of the element is inconsistent if you look at other dashboard widgets. They have 8px in all directions. Recommendations has 8px top/bottom only. Pragmatically speaking we can get this change in and tackle the rest later™ |
244ee3f to
686237d
Compare
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works!
|
/compile amend / |
Signed-off-by: Lukas Schaefer <[email protected]>
686237d to
79063b5
Compare
|
Rebuilt and merged as #875. Thanks a lot @lukasdotcom!! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |

Fixes: #855
Original:
Changes: