Skip to content

Conversation

@lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented May 11, 2025

Fixes: #855

Original:

image

Changes:

image

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find out why the outer element is growing so wide

@ChristophWurst
Copy link
Member

Thanks a lot for looking into this!!

@ChristophWurst
Copy link
Member

It's definitely better now, but I'm afraid this whole component structure needs a bit of a rewrite or a lot more duct tape.

The padding of the element is inconsistent if you look at other dashboard widgets. They have 8px in all directions. Recommendations has 8px top/bottom only.
There is also an issue that long names look fine on the dashboard, but take all their space when rendered on top of the file list.

Pragmatically speaking we can get this change in and tackle the rest later

@lukasdotcom lukasdotcom force-pushed the fix/dashboard_overflow branch 4 times, most recently from 244ee3f to 686237d Compare May 22, 2025 08:48
@lukasdotcom
Copy link
Member Author

So I did change the padding to do 8px around the entire widget. I added a picture below with the devtools highlighting the flexbox. I don't really have time for a complete rewrite currently, but the padding issue looked simple enough.
image

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@ChristophWurst
Copy link
Member

/compile amend /

@ChristophWurst
Copy link
Member

Rebuilt and merged as #875.

Thanks a lot @lukasdotcom!!

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 22, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Filenames extend past the Dashboard Widget UI

2 participants