feat(caldav): add repair steps in sabre calendarobject change hook #42347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
2. developing
tcitworld
requested review from
ChristophWurst and
miaulalala
as code owners
4 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Compare descriptions | ||
| $isSameDescription = (string) $oldObject->DESCRIPTION === (string) $newObject->DESCRIPTION; | ||
| $isSameXAltDesc = (string) $oldObject->{self::X_ALT_DESC_PROP_NAME} === (string) $newObject->{self::X_ALT_DESC_PROP_NAME}; | ||
| $isSameAltRep = (string) $oldObject->DESCRIPTION['ALTREP'] === (string) $newObject->DESCRIPTION['ALTREP']; |
Check failure
Code scanning / Psalm
InvalidCast
| // Compare descriptions | ||
| $isSameDescription = (string) $oldObject->DESCRIPTION === (string) $newObject->DESCRIPTION; | ||
| $isSameXAltDesc = (string) $oldObject->{self::X_ALT_DESC_PROP_NAME} === (string) $newObject->{self::X_ALT_DESC_PROP_NAME}; | ||
| $isSameAltRep = (string) $oldObject->DESCRIPTION['ALTREP'] === (string) $newObject->DESCRIPTION['ALTREP']; |
Check failure
Code scanning / Psalm
InvalidCast
|
|
||
| public function onCalendarObjectChange(?VCalendar $oldVCalendar, ?VCalendar $newVCalendar, bool &$modified): void { | ||
| $keyedOldComponents = []; | ||
| foreach ($oldVCalendar->children() as $child) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
| if (!($child instanceof Component)) { | ||
| continue; | ||
| } | ||
| $keyedOldComponents[$child->UID] = $child; |
Check notice
Code scanning / Psalm
PossiblyNullArrayOffset
|
|
||
| class Plugin extends ServerPlugin { | ||
|
|
||
| private Server $server; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| } | ||
|
|
||
| public function registerRepairStep(string $repairStep): self { | ||
| $this->addRepairStep(new $repairStep); |
Check notice
Code scanning / Psalm
InvalidStringClass
| } | ||
|
|
||
| public function registerRepairStep(string $repairStep): self { | ||
| $this->addRepairStep(new $repairStep); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
4 tasks
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a middleware repair step for calendar data before it's being saved or updated.
TODO
Checklist