fix(2fa): Handle twofactor_enforced configuration parameter as boolean

[jlehtoranta]

Summary

The twofactor_enforced configuration parameter should be handled as a boolean value like all the other boolean configuration parameters. This reduces configuration errors at least for those, who might edit config.php directly.

TODO

• Should we migrate the string values to boolean on current installations? Or make getSystemValueBool return the correct value regardless if it's e.g. 'true' or true?

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Fine by me, but didn't take the time to see if that behaves well on updates

[st3iny]

Thank you for the contribution.

However, this will break existing installations that are using a string, e.g. "false" will evaluate to true when cast to a boolean. I get where you are coming from but let's not refactor what is not broken. I don't know if it is a good idea to migrate config.php files.

Code example: https://3v4l.org/HMTpE

[nickvergessen]

However, this will break existing installations that are using a string, e.g. "false" will evaluate to true when cast to a boolean.

I always thought getSystemValueBool would cover that....
It definetly should from my POV?

[st3iny]

The current implementation is a bit naive: https://github.com/nextcloud/server/blob/master/lib%2Fprivate%2FAllConfig.php#L111