fix: restrict mime type list depending on check operator

[R0Wi]

• Resolves: Workflowengine "The given regular expression is invalid" #23666

Summary

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[R0Wi]

@blizzz I rebased this against the current master and adjusted to code to work with c24ead8.

Would be happy to see a review of this since me and other users are stumbling across the described issue regularly 😄

[R0Wi]

@susnux may I kindly ask you for a review, please?

[R0Wi]

@nextcloud/server-frontend anyone who could give me feedback, please?

[come-nc]

That does not work, because some predefined types are actually regex, like Images and Office documents, so those needs matches, while the others need is.

So we should have two lists of default values. Ideally things like "PDF documents" should be in both lists, once as regex and once as value to not confuse users.

[R0Wi]

Good catch! Thanks for your feedback @come-nc. I adjusted the code so that it now uses two predefined lists (with some intersections - for example for pdf there's a non-regex and a regex version now).

To be discusses: right now the custom value will only be visible on matches / !matches (regex). We could theoretically also allow custom non-regex mime-types but I didn't want to change this behavior.

Sidenote: I took the liberty to fix the custom values placeholder as well as this needs to be a valid regex

[R0Wi]

@come-nc the failing cypress tests seem to be unrelated? AFAIK there are no workflowengine E2E tests ...