refactor(account-management): Separate group views from internal views #51465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactoring of the route handling for the account management. We separate internal views like *disabled* or *recent* accounts from group views like *admin* or *custom-group-id*. The new URL looks like: `/settings/users/VIEW(/GROUP)` for example a real group like `admin` has this new URL: `/settings/users/group/admin`. While internal views like *recent* users look like: `/settings/users/recent`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
Contributor
|
Thanks for picking it up 🙏
|
Contributor
Author
|
joshtrichards
added
the
hotspot: account name handling
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some refactoring of the route handling for the account management. We separate internal views like disabled or recent accounts from group views like admin or custom-group-id.
The new URL looks like:
/settings/users/VIEW(/GROUP)for example a real group likeadminhas this new URL:/settings/users/group/admin.While internal views like recent users look like:
/settings/users/recent.Checklist