fix(sharing): ignore inexisting memberships during reshare check #52217
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
requested review from
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
come-nc
reviewed
Apr 17, 2025
Comment on lines
+1995
to
1996
| } catch (\Exception) { | ||
| return false; |
Contributor
There was a problem hiding this comment.
That’s a broad catch, at least log the exception on debug log level, no?
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to avoid an exception when a file is shared to multiple teams and current user is not a member of one of them.
Reproduce the original issue:
user1,user2,user3.team1withuser2+user3andteam2withuser2user1and shared touser2user2reshare the shared folder toteam1andteam2team1has no reshare permission,user3when browsing the right panel sharing tab will generate an exception.The reason for that is that when verifying resharing rights, all shares are checked until resharing permissions are found.
When checking those shares, if current user is not a member of recipient team, an exception is generated but not properly catched.