feature(files): add support for viewing public links in widget #52478

AIlkiv · 2025-04-26T12:56:40Z

Resolves: #

Summary

I added support for viewing public links to files.

For example: /index.php/s/Wnb3jd8PZqqd8kB or /s/Wnb3jd8PZqqd8kB

demo:

2025-04-26.15-34-15.mp4

I think this is an important PR for the entire community, because it will give us the opportunity to view videos and documents on the public page/collective (previously, this was not possible).

TODO

...

Checklist

Code is properly formatted
Sign-off message is added to all commits
[*] Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

susnux · 2025-05-07T14:25:17Z

cc @juliusknorr as reference picker / widget is mostly office

AIlkiv · 2025-05-08T12:43:24Z

I found out that it doesn't work for pictures and office files that “hide download”. I'll try to investigate why it doesn't work.

github-actions · 2025-05-11T02:11:33Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

juliusknorr · 2025-06-12T05:47:55Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+		return $reference;
+	}
+
+	public function resolveReferencePublic(string $referenceText, string $shareToken): ?IReference {


Suggested change

public function resolveReferencePublic(string $referenceText, string $shareToken): ?IReference {

public function resolveReferencePublic(string $referenceText, string $sharingToken): ?IReference {

As suggested by psalm to fit the interface definition

juliusknorr

Very minor nitpick as pointed out by the static analysis already, otherwise this is a very nice addition. Thanks a lot for this

blizzz

unfamiliar with the reference providers, but looks good. Left a remark, otherwise what Julius said.

(was meant to be non-blocking)

blizzz · 2025-06-12T09:29:18Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+					'x' => 1600,
+					'y' => 630,


not sure where these values come from, maybe worth to put them into a constant, or using an existing one?

Signed-off-by: ailkiv <[email protected]>

AIlkiv · 2025-07-10T20:01:19Z

Please adjust your commit message to pass CI:
- feature(files): add support for viewing public links in widget
+ feat(files): add support for viewing public links in widget
Also please run the code fixer locally:
composer cs:fix

@susnux done

nickvergessen

Objecting for now, will discuss later

provokateurin

Rich object values must be strings and the current could should be failing due to this 🤔

provokateurin · 2025-07-11T09:50:44Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+			$reference->setRichObject('file', [
+				'id' => $fileToken, // security, public link should not show file id
+				'name' => $node->getName(),
+				'size' => $node->getSize(),


Suggested change

'size' => $node->getSize(),

'size' => (string)$node->getSize(),

provokateurin · 2025-07-11T09:50:57Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+				'mimetype' => $node->getMimetype(),
+				'mtime' => $node->getMTime(),
+				'preview-available' => $this->previewManager->isAvailable($node),
+				'is-public-link' => true,


Suggested change

'is-public-link' => true,

'is-public-link' => 'yes',

provokateurin · 2025-07-11T09:51:06Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+				'link' => $reference->getUrl(),
+				'mimetype' => $node->getMimetype(),
+				'mtime' => $node->getMTime(),
+				'preview-available' => $this->previewManager->isAvailable($node),


Suggested change

'preview-available' => $this->previewManager->isAvailable($node),

'preview-available' => $this->previewManager->isAvailable($node) ? 'yes' : 'no',

AIlkiv · 2025-12-05T06:48:15Z

@nickvergessen Is there anything else I can do to improve this PR so that you will accept it?

nickvergessen · 2025-12-05T10:41:53Z

lib/private/Collaboration/Reference/File/FileReferenceProvider.php

+			$reference->setRichObject('file', null);
+			$reference->setAccessible(false);


this needs to log a brute-force attempt or needs some kind of other protection to not allow users to iterate public share links.
But if we add that, I can get you bruteforce protected by propering a document with a lot of share links you don't have access to.

I'm not sure this is solvable in a sensible and working way at the moment, so my objection still stands

AIlkiv requested review from a team and skjnldsv as code owners April 26, 2025 12:56

AIlkiv requested review from Altahrim, artonge and susnux and removed request for a team April 26, 2025 12:56

AIlkiv mentioned this pull request Apr 26, 2025

Failed to load attach video nextcloud/text#6872

Open

susnux added enhancement 3. to review Waiting for reviews labels Apr 26, 2025

susnux requested a review from juliusknorr April 26, 2025 20:06

susnux added this to the Nextcloud 32 milestone Apr 26, 2025

AIlkiv force-pushed the feature/public-link-file-preview-widget branch from 40357e0 to d7faa50 Compare May 7, 2025 12:38

github-actions bot added the feedback-requested label May 11, 2025

juliusknorr force-pushed the feature/public-link-file-preview-widget branch from d7faa50 to 2591948 Compare June 10, 2025 13:27

juliusknorr reviewed Jun 12, 2025

View reviewed changes

juliusknorr approved these changes Jun 12, 2025

View reviewed changes

juliusknorr force-pushed the feature/public-link-file-preview-widget branch from 2591948 to 24f87a9 Compare June 12, 2025 05:50

juliusknorr requested review from blizzz and luka-nextcloud June 12, 2025 05:51

blizzz reviewed Jun 12, 2025

View reviewed changes

blizzz approved these changes Jun 12, 2025

View reviewed changes

AIlkiv force-pushed the feature/public-link-file-preview-widget branch 4 times, most recently from 65fa5c0 to 12d5d9b Compare July 10, 2025 10:28

AIlkiv removed request for ArtificialOwl, ChristophWurst, SebastianKrupinski, hamza221, icewind1991, kesselb, miaulalala, nfebe, nickvergessen, provokateurin, st3iny and tcitworld July 10, 2025 19:42

feat(files): add support for viewing public links in widget

a248007

Signed-off-by: ailkiv <[email protected]>

AIlkiv force-pushed the feature/public-link-file-preview-widget branch from 90672a8 to a248007 Compare July 10, 2025 19:53

nickvergessen requested changes Jul 10, 2025

View reviewed changes

provokateurin requested changes Jul 11, 2025

View reviewed changes

This was referenced Aug 22, 2025

32.0.0 beta 2 #54581

Merged

32.0.0 beta 3 #54606

Merged

32.0.0 beta 4 #54688

Merged

This was referenced Sep 2, 2025

32.0.0 beta 5 #54796

Merged

[stable32] 32.0.0 RC1 #54864

Merged

nextcloud-bot mentioned this pull request Sep 10, 2025

[stable32] 32.0.0 RC2 #55000

Merged

nextcloud-bot mentioned this pull request Sep 18, 2025

[stable32] 32.0.0 RC3 #55162

Merged

This was referenced Sep 25, 2025

[stable32] 32.0.0 RC4 #55298

Merged

[stable32] 32.0.0 #55354

Merged

skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025

nickvergessen reviewed Dec 5, 2025

View reviewed changes

	public function resolveReferencePublic(string $referenceText, string $shareToken): ?IReference {
	public function resolveReferencePublic(string $referenceText, string $sharingToken): ?IReference {

	'size' => $node->getSize(),
	'size' => (string)$node->getSize(),

	'preview-available' => $this->previewManager->isAvailable($node),
	'preview-available' => $this->previewManager->isAvailable($node) ? 'yes' : 'no',

		$reference->setRichObject('file', null);
		$reference->setAccessible(false);

Uh oh!

feature(files): add support for viewing public links in widget #52478

Are you sure you want to change the base?

feature(files): add support for viewing public links in widget #52478

Uh oh!

Conversation

AIlkiv commented Apr 26, 2025

Summary

TODO

Checklist

Uh oh!

susnux commented May 7, 2025

Uh oh!

AIlkiv commented May 8, 2025

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

juliusknorr Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

juliusknorr left a comment

Choose a reason for hiding this comment

Uh oh!

blizzz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blizzz Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

AIlkiv commented Jul 10, 2025

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

provokateurin left a comment

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 11, 2025 • edited by nickvergessen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

provokateurin Jul 11, 2025 • edited by nickvergessen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AIlkiv commented Dec 5, 2025

Uh oh!

nickvergessen Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

blizzz left a comment •

edited

Loading

provokateurin Jul 11, 2025 •

edited by nickvergessen

Loading

provokateurin Jul 11, 2025 •

edited by nickvergessen

Loading