-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix interval option in occ background-job:worker
#53414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
83ada4d to
1086aa2
Compare
occ background-job:worker
|
/backport to stable31 |
1013a8c to
8bebe19
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
82027f4 to
0b390e3
Compare
ab3ac48 to
2a62aeb
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR title and description to the actual content change
occ background-job:workerocc background-job:worker
Done |
|
/backport to stable32 |
2a62aeb to
8f5626b
Compare
|
You pushed a fixup commit, can you merge that into the intended commit @salmart-dev |
Signed-off-by: Salvatore Martire <[email protected]>
8f5626b to
a9a5b25
Compare
Summary
Context
This PR comes from an investigation done for issue #49584
The user reported that running
occ background-job:worker --interval 5does not run jobs every 5 seconds as advertised.Upon investigation, I found out that the implementation for the
--intervaloption was never merged and the option seems to be a leftover from the PR where background workers were introduced.This PR makes uses the passed interval and follows the behaviour described in the parameter's description.
Checklist