Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Jun 10, 2025

Summary

Context

This PR comes from an investigation done for issue #49584

The user reported that running occ background-job:worker --interval 5 does not run jobs every 5 seconds as advertised.
Upon investigation, I found out that the implementation for the --interval option was never merged and the option seems to be a leftover from the PR where background workers were introduced.

This PR makes uses the passed interval and follows the behaviour described in the parameter's description.

Checklist

@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch from 83ada4d to 1086aa2 Compare June 10, 2025 09:34
@salmart-dev salmart-dev self-assigned this Jun 10, 2025
@salmart-dev salmart-dev changed the title Remove unused interval option Remove unused interval option from occ background-job:worker Jun 10, 2025
@salmart-dev salmart-dev added the 3. to review Waiting for reviews label Jun 10, 2025
@salmart-dev salmart-dev marked this pull request as ready for review June 10, 2025 10:51
@salmart-dev salmart-dev requested a review from a team as a code owner June 10, 2025 10:51
@salmart-dev salmart-dev requested review from nfebe, sorbaugh and yemkareems and removed request for a team June 10, 2025 10:51
@come-nc come-nc added this to the Nextcloud 32 milestone Jun 10, 2025
@salmart-dev
Copy link
Contributor Author

/backport to stable31

@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch 3 times, most recently from 1013a8c to 8bebe19 Compare June 23, 2025 09:55
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch 2 times, most recently from 82027f4 to 0b390e3 Compare June 30, 2025 10:11
@salmart-dev salmart-dev added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 1, 2025
This was referenced Aug 22, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 2, 2025
This was referenced Sep 4, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch from ab3ac48 to 2a62aeb Compare October 29, 2025 10:32
@nextcloud nextcloud deleted a comment from salmart-dev Oct 29, 2025
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR title and description to the actual content change

@salmart-dev salmart-dev changed the title Remove unused interval option from occ background-job:worker Fix interval option in occ background-job:worker Oct 29, 2025
@salmart-dev
Copy link
Contributor Author

Please update PR title and description to the actual content change

Done

@salmart-dev
Copy link
Contributor Author

/backport to stable32

@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch from 2a62aeb to 8f5626b Compare November 4, 2025 08:42
@nickvergessen
Copy link
Member

You pushed a fixup commit, can you merge that into the intended commit @salmart-dev

Signed-off-by: Salvatore Martire <[email protected]>
@salmart-dev salmart-dev force-pushed the fix/49584-background-worker-remove-interval branch from 8f5626b to a9a5b25 Compare November 4, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants