CLEAN: Enforce pdep6 #59007
Merged
CLEAN: Enforce pdep6 #59007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
enforce-pdep6
branch
from
6bdc2ec to
ed66194
Compare
MarcoGorelli
commented
Jun 14, 2024
MarcoGorelli
force-pushed
the
enforce-pdep6
branch
from
ed66194 to
abd4b9f
Compare
MarcoGorelli
commented
Jun 21, 2024
Comment on lines
+218
to
+219
| # Upcast so that we can add .5 | ||
| df = df.astype({"c": "float64"}) |
Member
Author
There was a problem hiding this comment.
manually adding this in so we can keep running the rest of the test
MarcoGorelli
force-pushed
the
enforce-pdep6
branch
from
abd4b9f to
9379c7b
Compare
MarcoGorelli
force-pushed
the
enforce-pdep6
branch
from
9379c7b to
45cafc2
Compare
MarcoGorelli
commented
Jun 28, 2024
mroeschke
reviewed
Jun 28, 2024
pandas/core/internals/blocks.py
Outdated
|
|
||
| @final | ||
| def coerce_to_target_dtype(self, other, warn_on_upcast: bool = False) -> Block: | ||
| def coerce_to_target_dtype(self, other, raise_on_upcast: bool = False) -> Block: |
Member
There was a problem hiding this comment.
Are there any usages of this method, outside this file, that does not set this to raise_on_upcast=False?
Member
Author
There was a problem hiding this comment.
there's no usage of this method at all outside this file
i've removed the default =False anyway, better to be explicit about this one
mroeschke
reviewed
Jul 5, 2024
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Code changes look good. Could you add something in the whatsnew (section or one-liner, up to you) about this enforcement?
mroeschke
approved these changes
Jul 8, 2024
Member
|
Thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few bits still need thinking over