Allow also $object::class with Identical

Author: ondrejmirtes

src/Analyser/TypeSpecifier.php

@@ -244,6 +244,25 @@ public function specifyTypesInCondition(
 				}
 			}
 
+			$rightType = $scope->getType($expr->right);
+			if (
+				$expr->left instanceof ClassConstFetch &&
+				$expr->left->class instanceof Expr &&
+				$expr->left->name instanceof Node\Identifier &&
+				$expr->right instanceof ClassConstFetch &&
+				$rightType instanceof ConstantStringType &&
+				strtolower($expr->left->name->toString()) === 'class'
+			) {
+				return $this->specifyTypesInCondition(
+					$scope,
+					new Instanceof_(
+						$expr->left->class,
+						new Name($rightType->getValue())
+					),
+					$context
+				);
+			}
+
 			if ($context->true()) {
 				$type = TypeCombinator::intersect($scope->getType($expr->right), $scope->getType($expr->left));
 				$leftTypes = $this->create($expr->left, $type, $context, false, $scope);
@@ -362,10 +381,7 @@ public function specifyTypesInCondition(
 			) {
 				return $this->specifyTypesInCondition(
 					$scope,
-					new Instanceof_(
-						$expr->left->class,
-						new Name($rightType->getValue())
-					),
+					new Expr\BinaryOp\Identical($expr->left, $expr->right),
 					$context
 				);
 			}

tests/PHPStan/Analyser/data/bug-4896.php

@@ -1,21 +1,38 @@
-<?php
+<?php // lint >= 8.0
 
 declare(strict_types = 1);
 
 namespace Bug4896;
 
 use function PHPStan\Testing\assertType;
 
-/** @var \DateTime|\DateInterval $command */
-$command = new \DateTime();
-
-switch ($command::class) {
-	case \DateTime::class:
-		assertType(\DateTime::class, $command);
-		var_dump($command->getTimestamp());
-		break;
-	case \DateInterval::class:
-		assertType(\DateInterval::class, $command);
-		echo " Hello Date Interval " . $command->format('d');
-		break;
+class Foo
+{
+
+	public function doFoo(\DateTime|\DateInterval $command): void
+	{
+		switch ($command::class) {
+			case \DateTime::class:
+				assertType(\DateTime::class, $command);
+				break;
+			case \DateInterval::class:
+				assertType(\DateInterval::class, $command);
+				break;
+		}
+
+	}
+
+}
+
+class Bar
+{
+
+	public function doFoo(\DateTime|\DateInterval $command): void
+	{
+		match ($command::class) {
+			\DateTime::class => assertType(\DateTime::class, $command),
+			\DateInterval::class => assertType(\DateInterval::class, $command),
+		};
+	}
+
 }

tests/PHPStan/Analyser/data/bug-5843.php

@@ -1,19 +1,35 @@
-<?php
+<?php // lint >= 8.0
 
 namespace Bug5843;
 
 use function PHPStan\Testing\assertType;
 
-function foo(object $object): void
+class Foo
 {
-	switch ($object::class) {
-		case \DateTime::class:
-			assertType(\DateTime::class, $object);
-			$object->modify('+1 day');
-			break;
-		case \Throwable::class:
-			assertType(\Throwable::class, $object);
-			$object->getPrevious();
-			break;
+
+	function doFoo(object $object): void
+	{
+		switch ($object::class) {
+			case \DateTime::class:
+				assertType(\DateTime::class, $object);
+				break;
+			case \Throwable::class:
+				assertType(\Throwable::class, $object);
+				break;
+		}
+	}
+
+}
+
+class Bar
+{
+
+	function doFoo(object $object): void
+	{
+		match ($object::class) {
+			\DateTime::class => assertType(\DateTime::class, $object),
+			\Throwable::class => assertType(\Throwable::class, $object),
+		};
 	}
+
 }