gh-119786: Remove mention of _PyThreadState_BumpFramePointer from InternalDocs/interpreter.md
#141816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
efimov-mikhail
requested review from
iritkatriel and
markshannon
and removed request for
AA-Turner
iritkatriel
reviewed
Nov 21, 2025
Co-authored-by: Irit Katriel <[email protected]>
iritkatriel
approved these changes
Nov 21, 2025
Member
|
how far back does this needs back porting? |
efimov-mikhail
added
needs backport to 3.13
Member
Author
|
Thx for the review, @iritkatriel! Backporting to 3.13 and 3.14 seems to be optimal, since this change was landed to 3.12, and docs changes are definitely not a security fixes. |
Member
|
we can back port doc updates to security fix versions |
Member
Author
|
Actually, we can backport only to 3.14, since there's no |
sergey-miryanov
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #93908 function
_PyThreadState_BumpFramePointerwas removed.But we still have its mention in
InternalDocs/interpreter.md.I propose to remove it and slightly change wording around.
For example, functions
_PyThreadState_HasStackSpaceand_PyFrame_PushUncheckedcould be mentioned.CC @iritkatriel @markshannon