Skip to content

Arguments without a default cannot follow attributes with one #17785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
embecka wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Arguments without a default cannot follow attributes with one #17785

embecka wants to merge 2 commits into from

Conversation

@embecka
Copy link

@embecka embecka commented Sep 19, 2024

Fixes #17731

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add a test for Application(5, name="asdf") to the test you changed as well? I think we might need a change for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

Assignees

No one assigned

Labels

upnext

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attributes without a default cannot follow attributes with one

2 participants

@embecka @hauntsaninja