Prevent errors if event-category tax is disabled #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If event-category taxonomy is disabled there will be an WP Error that should be checked too - same as for event-tag
Tax event-category can be disabled. If disabled there will be an WP Error if we try to query for event categories. Add a check for WP Errors as there is a check at event-tag will prevent the plugin from breaking if event-category is disabled.
Adds check in eo_get_event_meta_list for tax error
Owner
|
Thanks @ibes! |
Contributor
Author
|
Thank you for that great plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to disable event-tag and event-category (yeah!) but if event-category is disabled there will be problems with the event-meta information, as they try to query for both taxonomies and just for event-tag there is a check for WP Error.
Please add the check for event-category as well - on this both places.
I feel like my commit messages are not very clean. Maybe someone can help me by doing a cleaner merge request. The needed changes are simple.