Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

Conversation

@tiborvass
Copy link
Contributor

Also fixes a small bug with SetLegacyVersions.

Signed-off-by: Tibor Vass [email protected]

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

require.Equal(t, "LICENSE", targets[0].Name)



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super non-blocking nit: odd spacing here

@tiborvass tiborvass force-pushed the change-constructor-names branch 2 times, most recently from c848281 to 00799c2 Compare September 7, 2017 22:16
Copy link
Contributor

@NathanMcCauley NathanMcCauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also fixes a small bug with SetLegacyVersions.

Signed-off-by: Tibor Vass <[email protected]>
@tiborvass tiborvass force-pushed the change-constructor-names branch from 00799c2 to 87c5919 Compare September 8, 2017 00:15
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@endophage endophage merged commit 8a1de3c into notaryproject:master Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants