This repository was archived by the owner on Jul 31, 2025. It is now read-only.
return errors for invalid key pem blocks #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyazdf
approved these changes
Nov 3, 2017
Contributor
riyazdf
left a comment
riyazdf
left a comment
There was a problem hiding this comment.
thank you for adding this! I have one tiny non-blocking nit, but otherwise LGTM
trustmanager/keys.go
Outdated
| "sort" | ||
| "strings" | ||
|
|
||
| "fmt" |
Contributor
There was a problem hiding this comment.
super nit: let's move this to the block above with the other standard golang imports
Contributor
|
CI is failing with a |
Signed-off-by: Kyle Spiers <[email protected]>
Contributor
|
LGTM!
… On Nov 6, 2017, at 10:22 PM, Kyle Spiers ***@***.***> wrote:
@eiais commented on this pull request.
In trustmanager/keys.go:
> @@ -9,6 +9,7 @@ import (
"sort"
"strings"
+ "fmt"
fixed
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyle Spiers [email protected]