-
Notifications
You must be signed in to change notification settings - Fork 520
Add some filepaths on Fedora where libykcs11 may be found #1286
Add some filepaths on Fedora where libykcs11 may be found #1286
Conversation
Signed-off-by: Trishank K Kuppusamy <[email protected]>
|
Can one of the admins verify this patch? |
|
Hey, the linting failed: |
Signed-off-by: Trishank K Kuppusamy <[email protected]>
|
should be fixed now, i hope |
|
Jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Not sure what the codecov discrepancy is, but it seems unrelated.
Thanks for the update!
|
Please sign your commits following these rules: $ git clone -b "trishank_kuppusamy/fedora-pkcs11" [email protected]:trishankatdatadog/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354175080
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
|
Ah sorry, the "merge master" button in github breaks the DCO. :| Unfortunately you have to rebase. Not sure if this will help the coverage issues, but fingers crossed! |
|
No problem, sorry about that, let me get around to this ASAP |
4b1c6af to
ab433b8
Compare
|
I dropped the merge. Hope this helps. Thanks! |
I added some filepaths to the shared
libykcs11library may be found on Fedora after installingyubico-piv-tool.Signed-off-by: Trishank K Kuppusamy [email protected]