This repository was archived by the owner on Jul 31, 2025. It is now read-only.
Don't error out in case home cannot be found #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! (when tests are green >:) ) |
cyli
reviewed
Mar 21, 2018
| // Get home directory for current user | ||
| homeDir, err := homedir.Dir() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("cannot get current user home directory: %v", err) |
Contributor
There was a problem hiding this comment.
nit: we should specify that the default notary directory instead will be $(pwd)/.notary maybe, as part of the warning, since we are still setting a default, it just may be in an unexpected place.
Contributor
Author
There was a problem hiding this comment.
Oh I see what you mean, can definitely change that 😉
cyli
approved these changes
Mar 21, 2018
Contributor
cyli
left a comment
cyli
left a comment
There was a problem hiding this comment.
Other than a nitpick about being more clear in the warning that we may be writing data someplace the user doesn't expect, LGTM.
There is a few case where home could not be found (and would not be needed). Especially as this piece of code is only there to set a default value for a flag. Signed-off-by: Vincent Demeester <[email protected]>
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a few case where home could not be found (and would not be
needed). Especially as this piece of code is only there to set a
default value for a flag.
cc @cyli @n4ss @endophage
Signed-off-by: Vincent Demeester [email protected]