Changeset 2746625

Timestamp:

06/22/2022 07:08:23 PM (4 years ago)

Author:

grimmdude

Message:

More sanitizing

Location:

sharebar

Files:

• tags/1.4.3/sharebar-admin.php (modified) (2 diffs)
• trunk/sharebar-admin.php (modified) (2 diffs)

sharebar/tags/1.4.3/sharebar-admin.php

@@ -49 +49 @@
         $binaries = array("auto_posts","auto_pages","horizontal","credit");
         foreach($binaries as $binary) $_POST[$binary] = isset($_POST[$binary]) ? 1:0;
-        $_POST['width'] = $_POST['width'] ? $_POST['width']:1000;
+        $_POST['width'] = $_POST['width'] ? (int) $_POST['width']:1000;
         sharebar_settings($_POST);
         foreach($sharebar_options as $option) $$option = get_option('sharebar_'.$option);
@@ -55 +55 @@
         check_admin_referer( 'wp_sharebar_update_all' );
         $buttons = $_POST['buttons'];
-        $uptask = $_POST['update-task'];
+        $uptask = sanitize_text_field($_POST['update-task']);
         if($buttons){
             foreach ($buttons as $button)
-                sharebar_update_button($button,$uptask);
+                sharebar_update_button((int) $button,$uptask);
             $status = "Buttons have been ".esc_html($uptask)."d";
         }else

sharebar/trunk/sharebar-admin.php

@@ -49 +49 @@
         $binaries = array("auto_posts","auto_pages","horizontal","credit");
         foreach($binaries as $binary) $_POST[$binary] = isset($_POST[$binary]) ? 1:0;
-        $_POST['width'] = $_POST['width'] ? $_POST['width']:1000;
+        $_POST['width'] = $_POST['width'] ? (int) $_POST['width']:1000;
         sharebar_settings($_POST);
         foreach($sharebar_options as $option) $$option = get_option('sharebar_'.$option);
@@ -55 +55 @@
         check_admin_referer( 'wp_sharebar_update_all' );
         $buttons = $_POST['buttons'];
-        $uptask = $_POST['update-task'];
+        $uptask = sanitize_text_field($_POST['update-task']);
         if($buttons){
             foreach ($buttons as $button)
-                sharebar_update_button($button,$uptask);
+                sharebar_update_button((int) $button,$uptask);
             $status = "Buttons have been ".esc_html($uptask)."d";
         }else