Changeset 3116091

Timestamp:

07/11/2024 06:56:28 AM (18 months ago)

Author:

grimmdude

Message:

v4.5 - XSS vulnerability fix and deprecation notice.

Location:

simple-popup-plugin

Files:

• tags/4.5 (added)
• tags/4.5/readme.txt (added)
• tags/4.5/screenshot-1.png (added)
• tags/4.5/simple-popup-widget.php (added)
• tags/4.5/simple_popup_admin.php (added)
• tags/4.5/simple_popup_plugin.php (added)
• trunk/readme.txt (modified) (3 diffs)
• trunk/simple_popup_admin.php (modified) (4 diffs)
• trunk/simple_popup_plugin.php (modified) (2 diffs)

simple-popup-plugin/trunk/readme.txt

@@ -4 +4 @@
 Tags: popup,simple,tools,music,bands,musicians,pop-up,pop up,window,widget
 Requires at least: 2.8
-Tested up to: 6.0
-Stable tag: 4.4
+Tested up to: 6.5
+Stable tag: 4.5
 
 This plugin makes it easy to create a simple, modifiable popup window.
@@ -13 +13 @@
 
 Use this plugin to easily create links to simple popup windows.  It supports multiple popup links on posts/pages/widgets and window positioning/centering options.
-
-NEW to 4.2 - Fixed issue of toolbar/scrollbar/location bar options not working correctly.
 
 == Installation ==
@@ -72 +70 @@
 * Cleaned up options screen.
 
-== Upgrade Notice ==
-
-= 4.4 =
-* Fixed PHP7 depricated class constructor.
-* Fixed widget.
-* Cleaned up options screen.
+= 4.5 =
+* Fix XSS vulnerability.
+* Address has_cap deprecation notice.

simple-popup-plugin/trunk/simple_popup_admin.php

@@ -20 +20 @@
                 </th>
                 <td>
-                    <input type="text" id="popup_window_height" name="popup_window_height" value="<?php echo get_option('popup_window_height'); ?>" />
+                    <input type="text" id="popup_window_height" name="popup_window_height" value="<?php echo esc_attr(get_option('popup_window_height')); ?>" />
                 </td>
             </tr>
@@ -28 +28 @@
                 </th>
                 <td>
-                    <input type="text" id="popup_window_width" name="popup_window_width" value="<?php echo get_option('popup_window_width'); ?>" />
+                    <input type="text" id="popup_window_width" name="popup_window_width" value="<?php echo esc_attr(get_option('popup_window_width')); ?>" />
                 </td>
             </tr>
@@ -42 +42 @@
                 </th>
                 <td>
-                    <input type="text" id="popup_window_top" name="popup_window_top" value="<?php echo get_option('popup_window_top'); ?>" />
+                    <input type="text" id="popup_window_top" name="popup_window_top" value="<?php echo esc_attr(get_option('popup_window_top')); ?>" />
                 </td>
             </tr>
@@ -50 +50 @@
                 </th>
                 <td>
-                    <input type="text" id="popup_window_left" name="popup_window_left" value="<?php echo get_option('popup_window_left'); ?>" />
+                    <input type="text" id="popup_window_left" name="popup_window_left" value="<?php echo esc_attr(get_option('popup_window_left')); ?>" />
                 </td>
             </tr>

simple-popup-plugin/trunk/simple_popup_plugin.php

@@ -4 +4 @@
 Plugin URI: http://www.grimmdude.com/wordpress-simple-popup-plugin
 Description: This plugin makes it easy to create a simple, modifiable popup window.  Using the shortcode you can create a popup link and set the dimensions of each individual popup.
-Version: 4.4
+Version: 4.5
 Author: Garrett Grimm
-Author URI: http://www.grimmdude.com
+Author URI: https://grimmdude.com
 */
 
@@ -78 +78 @@
 
 function simple_popup_menu() {
-    add_options_page('Simple Popup Plugin Options', 'Simple Popup Plugin', 8, __FILE__, 'simple_popup_options');
+    add_options_page('Simple Popup Plugin Options', 'Simple Popup Plugin', 'administrator', __FILE__, 'simple_popup_options');
 }