add support for unpacking layers with xattrs set on FreeBSD #2170
Conversation
|
@dfr PTAL |
kimminss0
force-pushed
the
freebsd-xattr-support
branch
3 times, most recently
from
9e03882 to
6f059fa
Compare
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
A drive-by comment without really reading or understanding the code:
Could this be done without the run-time string comparison of GOOS (for every file)? That seems rather expensive, and it is not the idiomatic Go way.
I’d expect this to rely on Go build tags — maybe to have the setPlatformSpecificXattr function have a Linux/FreeBSD/unsupported variant; and for that function to both set the attribute and to make the decision whether to ignore the error.
kimminss0
force-pushed
the
freebsd-xattr-support
branch
4 times, most recently
from
573b448 to
6085ac5
Compare
|
LGTM - thanks for working on this |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimminss0, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kimminss0
force-pushed
the
freebsd-xattr-support
branch
from
6085ac5 to
b08c63f
Compare
This commit introduces wrappers for FreeBSD’s `extattr` system calls, enabling support for extended file attributes. Note that the `extattr` functionality on FreeBSD is analogous to Linux’s `xattr`. Signed-off-by: Minseo Kim <[email protected]>
…npacking This commit enables applying extended file attributes (xattr) to files during the unpacking of layers. The implementation mimics how FreeBSD's linux compatibility layer and BSD tar handles xattr using extattr system calls. Linux and FreeBSD supports different namespaces for extended attributes: - Linux: security, system, trusted, user - FreeBSD: system, user The `system` and `user` namespaces are directly mapped between the two systems. For unsupported namespaces on FreeBSD, such as `security` and `trusted`, the attributes are just dropped. Signed-off-by: Minseo Kim <[email protected]>
kimminss0
force-pushed
the
freebsd-xattr-support
branch
from
b08c63f to
28548e9
Compare
|
/lgtm |
5 participants
Closes #2168
This PR implements system call wrappers for
extattron FreeBSD, and adds support for unpacking layers with external attributes(xattr). The implementation mimics how FreeBSD's linux compatibility layer and BSD tar handles xattr using extattr system calls, while both has some limitations that only two of the namespacesuserandsystemare supported among the four – the rest,trustedandsecurityremain unsupported.