Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jul 17, 2025

Turns out container scanning is not using absolute paths in its results, which isn't breaking anything but is an assumption of our output package

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.58%. Comparing base (0bccdcd) to head (4452713).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2084   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files         170      170           
  Lines       16148    16149    +1     
=======================================
+ Hits        10913    10914    +1     
  Misses       4569     4569           
  Partials      666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath force-pushed the fix/always-be-absolute branch from b396eb8 to d2470a0 Compare July 17, 2025 00:53
@another-rex
Copy link
Collaborator

Interesting, it looks like the store absolute path option breaks layer tracing

@another-rex
Copy link
Collaborator

Opened this to fix it: google/osv-scalibr#916

@G-Rath G-Rath force-pushed the fix/always-be-absolute branch from d2470a0 to 91ceaba Compare July 31, 2025 20:02
@G-Rath G-Rath force-pushed the fix/always-be-absolute branch from 91ceaba to 4452713 Compare July 31, 2025 20:19
@G-Rath G-Rath marked this pull request as ready for review July 31, 2025 20:31
@another-rex another-rex merged commit 5b763a1 into google:main Aug 4, 2025
16 checks passed
@another-rex another-rex deleted the fix/always-be-absolute branch August 4, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants