Skip to content

Conversation

@another-rex
Copy link
Collaborator

Resolves #2081

@another-rex another-rex requested review from G-Rath, cuixq and hogo6002 July 21, 2025 07:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (641d7a9) to head (7cd1312).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmdlogger/handler.go 12.50% 12 Missing and 2 partials ⚠️
pkg/osvscanner/osvscanner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.02%     
==========================================
  Files         173      173              
  Lines       16326    16333       +7     
==========================================
+ Hits        11031    11033       +2     
- Misses       4618     4623       +5     
  Partials      677      677              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


func TestCommand_HtmlFile(t *testing.T) {
t.Parallel()
testutility.SkipIfNotAcceptanceTesting(t, "Needs container image")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yeah good point 😅

}

// SetCmdLogger sets the global slog handler for the cmdlogger.
func SetCmdLogger(handler slog.Handler) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like SetLogger would be more idiomatic, as the "cmd" part is an implementation detail right? and our goal is avoid having more than one logger that would necessitate more of these functions...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, updated this.

@another-rex another-rex merged commit 44a5169 into google:main Jul 23, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuration of the library's logging

4 participants