Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 6, 2025

This removes the external distinction between extractors and detectors in favor of just plugins, which matches how they're represented in scalibr

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.50%. Comparing base (c7499c2) to head (677cb71).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/osvscanner/scan.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   67.58%   67.50%   -0.08%     
==========================================
  Files         171      170       -1     
  Lines       16271    16232      -39     
==========================================
- Hits        10996    10957      -39     
  Misses       4600     4600              
  Partials      675      675              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath force-pushed the plugins/use-plugins branch 3 times, most recently from 8424175 to 8a1fd47 Compare August 6, 2025 21:30
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, though need to resolve the conflicts before the diffs are correct.

@G-Rath G-Rath force-pushed the plugins/use-plugins branch from c061d08 to 677cb71 Compare August 7, 2025 00:59
@G-Rath G-Rath marked this pull request as ready for review August 7, 2025 00:59
@another-rex another-rex enabled auto-merge (squash) August 7, 2025 01:03
@another-rex another-rex merged commit e28c9bc into google:main Aug 7, 2025
24 of 25 checks passed
@another-rex another-rex deleted the plugins/use-plugins branch August 7, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants