-
Notifications
You must be signed in to change notification settings - Fork 508
feat: merge extractor and detector flags into plugins
#2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 67.58% 67.50% -0.08%
==========================================
Files 171 170 -1
Lines 16271 16232 -39
==========================================
- Hits 10996 10957 -39
Misses 4600 4600
Partials 675 675 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8424175 to
8a1fd47
Compare
another-rex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, though need to resolve the conflicts before the diffs are correct.
c061d08 to
677cb71
Compare
This removes the external distinction between extractors and detectors in favor of just plugins, which matches how they're represented in scalibr