orphaned resources must be refreshed before plan #36394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of operations was incorrect here, with the refresh happening after the plan was already created. Invert the calls so the updated state is reflected in the plan output. We don't need to carry forward the defer response from refresh, since in the rare case that a read does need to be deferred, the PlanResourceChange call will return the same response.
jbardin
changed the title
liamcervante
approved these changes
Jan 24, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of operations was incorrect here, with the refresh happening after the plan was already created. Invert the calls so the updated state is reflected in the plan output.
We don't need to carry forward the defer response from refresh, since in the rare case that a read does need to be deferred, the PlanResourceChange call will return the same response.
Fixes #35568
Target Release
1.11.x
CHANGELOG entry