temporarily disable updated Go Windows symlink behavior #36575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvalSymlinks and Readlink on Windows used to return incorrect information for windows junctions which were specifically not symlinks prior to go1.23. Unfortunately Terraform uses `EvalSymlinks` in situations where Windows users had come to expect their configuration to work as if it were symlinked even though it used a different filesystem structure. Set winsymlink=0 to restore the existing behavior until we can determine the best course of action for Windows users.
jbardin
force-pushed
the
jbardin/winsymlink
branch
from
c7d3ac5 to
273b2b3
Compare
jbardin
added
the
1.11-backport
jbardin
force-pushed
the
jbardin/winsymlink
branch
from
273b2b3 to
863ded5
Compare
radeksimko
approved these changes
Feb 25, 2025
|
|
||
| go 1.24.0 | ||
|
|
||
| godebug winsymlink=0 |
Member
There was a problem hiding this comment.
TIL there is godebug stanza allowed here, I always assumed it's environment variables only
Member
Author
There was a problem hiding this comment.
it was new feature in go1.23 so you can build a module with GODEBUG options by default, which is perfect timing for this particular go1.23 problem ;)
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EvalSymlinks and Readlink on Windows used to return incorrect information for windows junctions which were specifically not symlinks prior to go1.23. Unfortunately Terraform uses
EvalSymlinksin situations where Windows users had come to expect their configuration to work as if it were symlinked even though it used a different filesystem structure. Setwinsymlink=0to restore the existing behavior until we can determine the best course of action for Windows users.Fixes #36545
Fixes #36357