Skip to content

Conversation

@liamcervante
Copy link
Contributor

This fixes a crash in 1.11 branch that occurs when a run block in a test file fails due to a non-applyable plan. It later tries to deference the null state and crashes. This was already fixed in main during a larger refactor in which the actual crash wasn't detected, so I'm pushing directly to 1.11.

We shouldn't merge this until after the 1.11.0 release happens later this week, with the target release for this PR being 1.11.1 next week.

I will forward port the test that was added here so we don't accidentally cause a regression in main.

Fixes #

Target Release

1.11.1

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@liamcervante liamcervante added the 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 26, 2025
@liamcervante liamcervante requested a review from a team as a code owner February 26, 2025 13:12
@liamcervante liamcervante merged commit 5fcae9a into v1.11 Mar 5, 2025
8 checks passed
@liamcervante liamcervante deleted the liamcervante/test-crash branch March 5, 2025 10:24
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants