make sure ephemeral nodes with zero instances work #36719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graph expansion code always wants a valid, non-empty graph now, but the ephemeral apply nodes could expand into zero instances and result in an empty graph. Make sure there is at least a root node to satisfy the graph validator during the apply walk.
jbardin
added
the
1.11-backport
dsa0x
approved these changes
Mar 19, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph expansion code always wants a valid, non-empty graph now, but the ephemeral apply nodes could expand into zero instances and result in an empty graph. Make sure there is at least a root node to satisfy the graph validator during the apply walk.
Fixes #36714
Target Release
1.11.x