Import references should not be able to reference the import target #36801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
force-pushed
the
sams/import-self-ref
branch
from
3f11d1b to
9829f4f
Compare
jbardin
reviewed
Mar 31, 2025
dsa0x
force-pushed
the
sams/import-self-ref
branch
from
7600af5 to
29351bb
Compare
jbardin
previously approved these changes
Mar 31, 2025
Member
|
FYI your |
jbardin
reviewed
Mar 31, 2025
| body: for_each expressions in import blocks should not be able to reference the import target | ||
| time: 2025-03-31T15:08:02.156881+02:00 | ||
| custom: | ||
| Issue: "36672" |
Member
There was a problem hiding this comment.
This should point to the PR, not the issue
dsa0x
commented
Apr 1, 2025
liamcervante
approved these changes
Apr 1, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the import block from being able to reference anywhere else the resource in its "to" attribute, as that will lead to a cyclic dependency.
Fixes #36672
Target Release
1.12.x
CHANGELOG entry