Skip to content

Conversation

@dsa0x
Copy link
Member

@dsa0x dsa0x commented Jul 4, 2025

Fixes #

When #36323 introduced the parallelism flag for limiting plan/apply operations concurrency, we agreed that a new flag would likely be needed for the run parallelism. Until now, the value for run concurrency was not set and we have just been using the default of 10. That's why it never got surfaced that there is a bug where a deadlock would occur when the run parallelism is set to 1

What led me to this is discovering that a parallelism of 1 will result in a deadlock if nodes that create subgraphs also acquire the lock.

1.13.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x marked this pull request as ready for review July 4, 2025 17:00
@dsa0x dsa0x requested a review from a team as a code owner July 4, 2025 17:00
@dsa0x dsa0x merged commit a133229 into main Jul 7, 2025
14 checks passed
@dsa0x dsa0x deleted the sams/fix-run-parallelism branch July 7, 2025 07:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants