Test run Parallelism of 1 should not result in deadlock #37292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
When #36323 introduced the parallelism flag for limiting plan/apply operations concurrency, we agreed that a new flag would likely be needed for the run parallelism. Until now, the value for run concurrency was not set and we have just been using the default of 10. That's why it never got surfaced that there is a bug where a deadlock would occur when the run parallelism is set to 1
What led me to this is discovering that a parallelism of 1 will result in a deadlock if nodes that create subgraphs also acquire the lock.
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry