[PhpAttribute] Ensure count($attributeGroups) !== 1 check before loop to avoid repetitive annotation produce only single AttributeGroup on GenericAnnotationToAttributeConverter #6985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…petitive annotation product only single AttributeGroup
samsonasik
changed the title
samsonasik
changed the title
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
Let's merge this as safe belt ;) |
Comment on lines
+90
to
+92
| if (count($attributeGroups) !== 1) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
This hides implementation even more, let's revert.
Member
Author
There was a problem hiding this comment.
The issue without this is, the loop annotation removal may invalid, as we only apply single AttributeGroup, as 1 AtrributeGroup is 1 line annotation, need loop removal become buggy
Member
There was a problem hiding this comment.
This service is only used for our internal rules with non-repeatable annotatoins. We're safe.
In case this will show buggy in the future, we'll handle it. YAGNI :)
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6984 (review) , single AttributeGrup result, or skip.