Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 19, 2025

Given the following code:

final class SkipGenericIterable
{
    #[\JMS\Serializer\Annotation\Type('iterable<SomeType>')]
    private $name;
}

It cause change:

-    private $name;
+    private ?\iterable<SomeType> $name = null;

which make crash:

ParseError: syntax error, unexpected token "<", expecting "," or ";"

see https://3v4l.org/3foP0

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 21d059f into main Jun 19, 2025
45 checks passed
@samsonasik samsonasik deleted the crash-generic-iterable branch June 19, 2025 12:00
@TomasVotruba
Copy link
Member

Yes, thank you 👏

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants