Skip to content

Conversation

@svlandeg
Copy link
Member

As discussed in #502 (comment):

This PR covers too many different things, so it would be better to split it to be able to take some things while not taking others.

Specifically, I would take the changes in the Click examples from "some str {blah}".format(blah=blah) to f-strings. That was just an exact copy of Click's tutorials, but now they updated them, we can update them here as well.

Thanks to @marksmayo for originally catching these cases 🙏

@svlandeg svlandeg mentioned this pull request Jul 26, 2024
@github-actions
Copy link
Contributor

📝 Docs preview for commit 6437826 at: https://114d8aa1.typertiangolo.pages.dev

@svlandeg svlandeg added feature New feature, enhancement or request refactor p3 and removed refactor labels Jul 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

📝 Docs preview for commit 8bb1882 at: https://64482858.typertiangolo.pages.dev

svlandeg added a commit that referenced this pull request Aug 21, 2024
@svlandeg
Copy link
Member Author

Note that if we end up merging #938, we can simply close this one. Or we can merge this one first, and update the other one afterwards 🤷.

@tiangolo tiangolo changed the title ♻️ Use F-strings in Click examples ♻️ Use F-strings in Click examples in docs Aug 24, 2024
@tiangolo tiangolo added docs Improvements or additions to documentation and removed feature New feature, enhancement or request labels Aug 24, 2024
@tiangolo
Copy link
Member

Nice, thank you! 🚀 🍰

@tiangolo tiangolo merged commit f6cbe25 into fastapi:master Aug 24, 2024
@svlandeg svlandeg deleted the feat/fstrings branch August 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation p3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants