Swap emulator Node runtime discovery to favor local cache#2740
Merged
Conversation
Contributor
Author
|
Addresses issues of #2380 so the developer is given the commands to resolve the issue when running in firepit |
samtstern
approved these changes
Oct 26, 2020
Contributor
|
@abeisgoat don't forget a |
…hub.com/firebase/firebase-tools into ah/functions-emulator-discover-npm-node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we always assume the healthiest node install you have is the global one, this isn't the case when running in firepit, so I've swapped the preference to prefer any version of node installed to
node_modules(if it exists and matches the requested runtime version).