Skip to content

feat(iam, app): adds Bright Id Stamp#126

Merged
gdixon merged 1 commit into
mainfrom
brightid-stamp-wip
Jun 1, 2022
Merged

feat(iam, app): adds Bright Id Stamp#126
gdixon merged 1 commit into
mainfrom
brightid-stamp-wip

Conversation

@farque65

@farque65 farque65 commented May 31, 2022

Copy link
Copy Markdown
Contributor
  • adds BrightId verification steps on iam server failure
  • adds toast messages
  • adds procedures to verify and sponsor a user with BrightId
  • Added BRIGHTID_PRIVATE_KEY to Review, Staging and Production AWS Secret Managers

Closes #1

Comment thread app/components/ProviderCards/BrightidCard.tsx Outdated
Comment thread app/components/ProviderCards/BrightidCard.tsx
Comment thread app/config/providers.ts Outdated
Comment thread app/context/userContext.tsx Outdated
Comment thread iam/package.json
Comment thread iam/src/procedures/brightid.ts Outdated
Comment thread iam/src/procedures/brightid.ts Outdated
Comment thread types/src/brightid.d.ts Outdated
Comment thread yarn.lock Outdated
@farque65 farque65 force-pushed the brightid-stamp-wip branch from a4f8655 to eb42011 Compare June 1, 2022 04:16
@farque65 farque65 requested a review from shavinac June 1, 2022 13:49

@shavinac shavinac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking, but it seems like the new ed25519-related dependencies in app/package.json aren't used anymore?

@farque65 farque65 force-pushed the brightid-stamp-wip branch from eb42011 to 9bc9153 Compare June 1, 2022 14:06
@farque65

farque65 commented Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

ed25519

This is a quick change. I just pushed changes to resolve this

export const SUCCESFUL_BRIGHTID_RESULT: VerifiableCredentialRecord = {
record: {
type: "Brightid",
address: "0xcF323CE817E25b4F784bC1e14c9A99A525fDC50f",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real address?

@farque65 farque65 Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@gdixon gdixon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my comments are mostly on test files with the exception of the selfID.id comments -

I have some changes going in shortly which should ensure that the userDid is the users did:pkh - so I think we can go ahead and merge this and fix everything up in my PR.

Comment thread app/__test-fixtures__/verifiableCredentialResults.ts Outdated
Comment thread app/context/userContext.tsx Outdated
Comment thread iam/__tests__/brightid.test.ts Outdated
- adds BrightId verification steps on iam server failure
- adds toast messages
- adds procedures to verify and sponsor a user with BrightId

Closes #1
@farque65 farque65 force-pushed the brightid-stamp-wip branch from 9bc9153 to 059e40a Compare June 1, 2022 14:47
@gdixon gdixon merged commit e725609 into main Jun 1, 2022
@farque65 farque65 deleted the brightid-stamp-wip branch June 1, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎫 [STAMPS] As a Passport Holder, I can add a BrightID stamp to my passport

3 participants