Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: Use the key instead of the value to verify the number of channels created in ChannelUsageTest#1965

Merged
blakeli0 merged 1 commit into
mainfrom
fix-unit-test
Aug 9, 2022
Merged

fix: Use the key instead of the value to verify the number of channels created in ChannelUsageTest#1965
blakeli0 merged 1 commit into
mainfrom
fix-unit-test

Conversation

@blakeli0

@blakeli0 blakeli0 commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

This is to fix an issue where the test would fail if the value of the key changes in gRPC. See #1960 for details.

…s created in ChannelUsageTest.

This is to fix an issue where the test would fail if the value of the key changes in gRPC.
@blakeli0 blakeli0 requested a review from a team August 4, 2022 22:25
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 4, 2022
@blakeli0 blakeli0 requested a review from ansh0l August 4, 2022 22:25
@blakeli0 blakeli0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2022
@suztomo

suztomo commented Aug 8, 2022

Copy link
Copy Markdown
Member

@ansh0l Can you take a look. This pull request (which fixes #1960) is a blocker for our BOM release.

@blakeli0 blakeli0 merged commit ea329bb into main Aug 9, 2022
@blakeli0 blakeli0 deleted the fix-unit-test branch August 9, 2022 15:38
gcf-owl-bot Bot added a commit that referenced this pull request Jun 5, 2024
Source-Link: googleapis/synthtool@bd2bae8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:72f0d373307d128b2cb720c5cb4d90b31f0e86529dd138c632710ae0c69efae3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants