Skip to content

fix: Don't wrongly discard text immediately before an autodoc#207

Merged
pawamoy merged 1 commit into
mkdocstrings:masterfrom
oprypin:keep
Dec 30, 2020
Merged

fix: Don't wrongly discard text immediately before an autodoc#207
pawamoy merged 1 commit into
mkdocstrings:masterfrom
oprypin:keep

Conversation

@oprypin

@oprypin oprypin commented Dec 30, 2020

Copy link
Copy Markdown
Member
foo
**foo**
::: some.identifier

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the autodoc will be rendered as well.

```markdown
foo
**foo**
::: some.identifier
```

In the previous state, the "foo" text would be completely obliterated, but now it will be kept, and the autodoc will be rendered as well.
@oprypin

oprypin commented Dec 30, 2020

Copy link
Copy Markdown
Member Author

touché

@pawamoy

pawamoy commented Dec 30, 2020

Copy link
Copy Markdown
Member

This is great!

I guess it's an in-house workaround for Markdown versions lower than the next one containing your fix.

@oprypin

oprypin commented Dec 30, 2020

Copy link
Copy Markdown
Member Author

No no, this is just another issue, one that is exactly parallel to the linked one, just that we happened to notice the linked one first

@pawamoy

pawamoy commented Dec 30, 2020

Copy link
Copy Markdown
Member

Oh OK, thank you for the explanation 🙂
EDIT: yes now that I re-read it carefully it's obvious 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants