Skip to content

Commit 5664ce2

Browse files
vursenclaude
andauthored
refactor: remove redundant _afterScroll call after creating grid rows (#11917)
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent dd010a5 commit 5664ce2

2 files changed

Lines changed: 1 addition & 11 deletions

File tree

‎packages/grid/src/vaadin-grid-mixin.js‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
55
*/
66
import { TabindexMixin } from '@vaadin/a11y-base/src/tabindex-mixin.js';
7-
import { animationFrame, microTask } from '@vaadin/component-base/src/async.js';
7+
import { microTask } from '@vaadin/component-base/src/async.js';
88
import { isAndroid, isChrome, isFirefox, isIOS, isSafari, isTouch } from '@vaadin/component-base/src/browser-utils.js';
99
import { Debouncer } from '@vaadin/component-base/src/debounce.js';
1010
import { getClosestElement } from '@vaadin/component-base/src/dom-utils.js';
@@ -360,13 +360,6 @@ export const GridMixin = (superClass) =>
360360
});
361361
}
362362

363-
this.__afterCreateScrollerRowsDebouncer = Debouncer.debounce(
364-
this.__afterCreateScrollerRowsDebouncer,
365-
animationFrame,
366-
() => {
367-
this._afterScroll();
368-
},
369-
);
370363
return rows;
371364
}
372365

‎packages/grid/test/dom/__snapshots__/grid.test.snap.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,6 @@ snapshots["vaadin-grid basic shadow details opened"] =
776776
snapshots["vaadin-grid basic shadow hidden column"] =
777777
`<div
778778
id="scroller"
779-
scrolling=""
780779
style=""
781780
>
782781
<table
@@ -965,7 +964,6 @@ snapshots["vaadin-grid basic shadow hidden column"] =
965964
snapshots["vaadin-grid basic shadow hidden column selected"] =
966965
`<div
967966
id="scroller"
968-
scrolling=""
969967
style=""
970968
>
971969
<table
@@ -1155,7 +1153,6 @@ snapshots["vaadin-grid basic shadow hidden column selected"] =
11551153
snapshots["vaadin-grid basic shadow with footer"] =
11561154
`<div
11571155
id="scroller"
1158-
scrolling=""
11591156
style=""
11601157
>
11611158
<table

0 commit comments

Comments
 (0)