Skip to content

Commit d307814

Browse files
authored
refactor!: update Aura master-detail-layout detail shadow, radius, and inset (#11503)
1 parent b99ce24 commit d307814

8 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎packages/aura/src/components/master-detail-layout.css‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ vaadin-master-detail-layout[has-detail][overlay]::part(detail) {
1111
--vaadin-master-detail-layout-detail-shadow,
1212
inset 1px 0 0 0 var(--aura-overlay-inner-outline-color),
1313
-1px 0 0 0 var(--aura-overlay-outline-color),
14-
var(--aura-shadow-m)
14+
var(--aura-overlay-shadow)
15+
);
16+
--_inset: var(--aura-master-detail-layout-detail-inset, round(var(--aura-app-layout-inset) / 1.5, 1px));
17+
margin: var(--_inset);
18+
border-radius: clamp(
19+
0px,
20+
var(--_inset) * 1000,
21+
max(var(--vaadin-radius-m), var(--vaadin-radius-l) - round(var(--_inset) / 2, 1px))
1522
);
1623
}
1724

1825
vaadin-master-detail-layout[has-detail][overlay][overlay-containment='page']::part(detail) {
19-
box-shadow: var(--vaadin-master-detail-layout-detail-shadow, var(--aura-overlay-shadow));
20-
}
21-
22-
/* TODO could be a built-in variant */
23-
vaadin-master-detail-layout[theme~='inset-drawer'][has-detail][overlay]::part(detail),
24-
vaadin-master-detail-layout[has-detail][overlay][overlay-containment='page']::part(detail) {
25-
margin: calc(var(--aura-app-layout-inset) / 2);
26-
border-radius: var(--_app-layout-radius);
26+
border-radius: clamp(0px, var(--_inset) * 1000, var(--vaadin-radius-l));
2727
}
2828

2929
vaadin-master-detail-layout > vaadin-master-detail-layout,

‎packages/master-detail-layout/test/visual/aura/master-detail-layout.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ describe('master-detail-layout', () => {
5050
await visualDiff(document.body, 'drawer-page');
5151
});
5252

53-
it('inset-drawer', async () => {
54-
mdl.setAttribute('theme', 'inset-drawer');
53+
it('inset', async () => {
54+
mdl.style.setProperty('--aura-master-detail-layout-detail-inset', '0px');
5555
await visualDiff(element, 'drawer-inset');
5656
});
5757
});
1.83 KB
Loading
-1.31 KB
Loading
1.01 KB
Loading
5.39 KB
Loading
-4.22 KB
Loading
1003 Bytes
Loading

0 commit comments

Comments
 (0)