Add width and height attributes to source elements#5894
Merged
domenic merged 38 commits intoFeb 25, 2021
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4968
I believe this has multi-implementer interest, based on #4968 (comment), but will let others comment to that effect.
This doesn't yet have tests, as I wanted to first verify the approach I took makes sense. I'll make sure tests are added before landing. Similarly, I'll make sure implementation bugs are opened.
/cc @zcorpan @annevk @domenic @chrishtr @emilio @jensimmons @cbiesinger
(See WHATWG Working Mode: Changes for more details.)
/embedded-content-other.html ( diff )
/embedded-content.html ( diff )
/images.html ( diff )
/indices.html ( diff )
/rendering.html ( diff )