Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

feat: add label fullStacktrace#40

Merged
athakor merged 2 commits into
googleapis:masterfrom
athakor:logging-34
Dec 13, 2019
Merged

feat: add label fullStacktrace#40
athakor merged 2 commits into
googleapis:masterfrom
athakor:logging-34

Conversation

@athakor

@athakor athakor commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

Fixes #34

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@codecov

codecov Bot commented Dec 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage     76.24%   76.24%           
  Complexity      571      571           
=========================================
  Files            42       42           
  Lines          3334     3334           
  Branches        232      232           
=========================================
  Hits           2542     2542           
  Misses          647      647           
  Partials        145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5c129...41bca75. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@athakor athakor requested a review from chingor13 December 5, 2019 07:23
.put("levelName", "ERROR")
.put("levelValue", String.valueOf(40000L))
.put("loggerName", this.getClass().getName())
.put("fullStacktrace", "this is a test".trim())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's an extra space

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@athakor athakor merged commit 43e1953 into googleapis:master Dec 13, 2019
@athakor athakor deleted the logging-34 branch December 13, 2019 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacktrace should not be written to log message

5 participants