PSAlignAssignmentStatement: Ignore hashtables with a single key-value pair#1983
Closed
liamjpeters wants to merge 2 commits intoPowerShell:masterfrom
Closed
PSAlignAssignmentStatement: Ignore hashtables with a single key-value pair#1983liamjpeters wants to merge 2 commits intoPowerShell:masterfrom
liamjpeters wants to merge 2 commits intoPowerShell:masterfrom
Conversation
…g on a single line, and not checked for violations.
6 tasks
Collaborator
|
@liamjpeters what was the issue or reason for closing this PR? Happy to support/help where needed |
Contributor
Author
|
@bergmeister - I'm not the most familiar with git. I used the main branch of my fork for this PR but wanted to use a different branch. Didn't know how to do that so got things organised locally, closed this PR and opened a new one. #1986 Hopefully I've not created any issues by doing so |
Collaborator
|
Gotcha, no worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Hashtables with a single key-value pair should be ignored by
PSAlignAssignmentStatementas there is nothing to align.There are other rules that handle whitespace around operators etc which can handle formatting according to the users preference.
Currently:
Results in:
Note the space added after the hashtable key
Resolves #1979
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.