This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Improve @return inline docs for rest_ensure_response() #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rachelbaker I refreshed the patch with more details on what is returned. |
Member
|
The line needs to be re-wrapped to 80 characters to match what we have there, or put all on one line. I'm easy either way. |
Contributor
Author
|
@rmccue Should be good now. |
Member
|
Small spelling mistake here with "rerurns" Happy to merge immediately once fixed. :) |
Member
|
Weirdly, the Scrutinizer build failed, not sure why on that. @Shelob9 Thanks for the PR :) |
rmccue
added a commit
that referenced
this pull request
Jul 23, 2015
Improve @return inline docs for rest_ensure_response()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing docs use "mixed" as the data type for return. That does not allow autocompletion doc reference for
rest_ensure_response()in phpStorm, which made me sad.